Patient, enthusiastic, energetic, supportive, had a sense of humor, and willing to help stragglers. My favorite teacher, was strangely philosophical at times for an IT, electronics, and computer science teacher. His words effect me the most from all my teachers, in my time in High School. I still reflect back to some of the things he said, and apply it to all aspects of my life.
And sometimes, he'd create an incentive. Shoot to do well in his courses, so he'd create a free day where everyone can bring in their PC/console to play video games all afternoon.
Similar to my favorite teacher, there were two others with the same qualities. My graphic arts teacher and drama teacher. Which were also favorites, but they were only my teachers briefly.
Runner ups would be the English teachers I had in my final year. Which had most of those qualities. The history teacher was kinda cool too, in Grade 11. Very funny at times.
One of the Math teachers was amusing. She treated her job kinda like a Late Night talk show host. Talking to random students during class time in the room. Making jokes.